[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macr
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macro |
Date: |
Tue, 18 Jul 2017 12:19:53 +0100 |
User-agent: |
mu4e 0.9.19; emacs 25.2.50.3 |
Juan Quintela <address@hidden> writes:
> Philippe Mathieu-Daudé <address@hidden> wrote:
>> Applied using the Coccinelle semantic patch
>> scripts/coccinelle/use_osdep.cocci
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> migration/block.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/migration/block.c b/migration/block.c
>> index 9171f60028..498c72ad59 100644
>> --- a/migration/block.c
>> +++ b/migration/block.c
>> @@ -933,7 +933,7 @@ static int block_load(QEMUFile *f, void *opaque, int
>> version_id)
>> ret = bdrv_get_info(blk_bs(blk), &bdi);
>> if (ret == 0 && bdi.cluster_size > 0 &&
>> bdi.cluster_size <= BLOCK_SIZE &&
>> - BLOCK_SIZE % bdi.cluster_size == 0) {
>> + QEMU_IS_ALIGNED(BLOCK_SIZE, bdi.cluster_size)) {
>> cluster_size = bdi.cluster_size;
>> } else {
>> cluster_size = BLOCK_SIZE;
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> Should I take this patch, or does it go through the block layer? Your
> call.
Given it is part of a set would it not make more sense going through
-trivial with the rest of them?
--
Alex Bennée
- [Qemu-devel] [PATCH 01/29] coccinelle: add a script to enforce qemu/osdep.h macros usage, (continued)
- [Qemu-devel] [PATCH 01/29] coccinelle: add a script to enforce qemu/osdep.h macros usage, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 03/29] qemu-img: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 04/29] scsi-disk: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 05/29] block: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 08/29] ui: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 10/29] net/rocker: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 09/29] net: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 11/29] s390x/sclp: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18