[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws |
Date: |
Tue, 18 Jul 2017 17:08:25 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Jul 18, 2017 at 03:41:16PM +0200, Markus Armbruster wrote:
> blockdev-add and migrate-set-parameters overload empty strings to mean
> something entirely different. See my memo "qapi: Stop abusing
> "special" values for something entirely different" for details.
>
> Message-ID: <address@hidden>
> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04526.html
>
> This series deprecates these usages of "" in favour of JSON null.
> Because we're so close to the 2.10 freeze, the implementation is
> intentionally stupid: rewrite null to "" at first opportunity. The
> proper way to do it would be rewriting "" to null, but that requires
> fixing up code to work with null. There are TODO comments for that.
> I'm willing to take care of them in the next development cycle.
I tested the migrate-set-parameters QMP command with this applied and
I can still pass "" as the tls-hostname.
When using query-migrate-parameters we still see "" too.
So from POV of avoiding regressions for existing usage, we look OK
here.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default, (continued)
Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default, Dr. David Alan Gilbert, 2017/07/18
[Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now, Markus Armbruster, 2017/07/18
Re: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws, no-reply, 2017/07/18
Re: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws,
Daniel P. Berrange <=