qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu.py small fixes


From: no-reply
Subject: Re: [Qemu-devel] [PATCH 0/3] scripts/qemu.py small fixes
Date: Tue, 18 Jul 2017 11:59:12 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/3] scripts/qemu.py small fixes
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3f76a61 qemu.py: make 'args' public
0153001 qemu.py: include debug information on launch error
31a1f63 qemu.py: fix is_running()

=== OUTPUT BEGIN ===
Checking PATCH 1/3: qemu.py: fix is_running()...
Checking PATCH 2/3: qemu.py: include debug information on launch error...
ERROR: unnecessary whitespace before a quoted newline
#94: FILE: scripts/qemu.py:147:
+                       "Original Exception: \n%s\n"

total: 1 errors, 0 warnings, 39 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: qemu.py: make 'args' public...
ERROR: line over 90 characters
#52: FILE: scripts/qemu.py:171:
+                sys.stderr.write('qemu received signal %i: %s\n' % (-exitcode, 
' '.join(self.args)))

total: 1 errors, 0 warnings, 75 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]