[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/11] qmp.py: Use object-based class for QEMUMo
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 07/11] qmp.py: Use object-based class for QEMUMonitorProtocol |
Date: |
Thu, 20 Jul 2017 15:35:22 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Jul 20, 2017 at 06:28:11PM +0200, Lukáš Doktor wrote:
> There is no need to define QEMUMonitorProtocol as old-style class.
>
> Signed-off-by: Lukáš Doktor <address@hidden>
> ---
> scripts/qmp/qmp.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py
> index bb4d614..68f3420 100644
> --- a/scripts/qmp/qmp.py
> +++ b/scripts/qmp/qmp.py
> @@ -30,7 +30,7 @@ class QMPTimeoutError(QMPError):
> pass
>
>
> -class QEMUMonitorProtocol:
> +class QEMUMonitorProtocol(object):
I don't fully understand the consequences of changing to
new-style classes when using old-style SuperClass.__init__()
calls in the __init__(). Should we change QMPShell.__init__() to
use super()?
>
> #: Socket's error class
> error = socket.error
> --
> 2.9.4
>
--
Eduardo
- Re: [Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object, (continued)
[Qemu-devel] [PATCH 10/11] qtest.py: Few pylint/style fixes, Lukáš Doktor, 2017/07/20
[Qemu-devel] [PATCH 01/11] qemu.py: Pylint/style fixes, Lukáš Doktor, 2017/07/20
[Qemu-devel] [PATCH 07/11] qmp.py: Use object-based class for QEMUMonitorProtocol, Lukáš Doktor, 2017/07/20
- Re: [Qemu-devel] [PATCH 07/11] qmp.py: Use object-based class for QEMUMonitorProtocol,
Eduardo Habkost <=
[Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes, Lukáš Doktor, 2017/07/20