[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/3] qemu-iotests: add _require_feature() function
From: |
Cleber Rosa |
Subject: |
[Qemu-devel] [PATCH 2/3] qemu-iotests: add _require_feature() function |
Date: |
Thu, 20 Jul 2017 23:47:29 -0400 |
With the previously introduced buildconf.py script, it's possible
to determine if a feature needed by a test is present or not. This
adds a thin layer on top of scripts/buildconf.py, and allows tests
to be skipped when a feature is required.
The naming of the function, while different in tense from the
_supported_* family of functions, was chosen to match the style
of _require_command(), which seems pretty similar.
Signed-off-by: Cleber Rosa <address@hidden>
---
tests/qemu-iotests/check | 2 ++
tests/qemu-iotests/common.rc | 7 +++++++
2 files changed, 9 insertions(+)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 2a55ec9..c0f4004 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -60,6 +60,8 @@ fi
build_root="$build_iotests/../.."
+export BUILDCONF="$build_root/scripts/buildconf.py"
+
if [ -x "$build_iotests/socket_scm_helper" ]
then
export SOCKET_SCM_HELPER="$build_iotests/socket_scm_helper"
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index 2548e58..19b3111 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -470,6 +470,13 @@ _require_command()
[ -x "$c" ] || _notrun "$1 utility required, skipped this test"
}
+# tests whether a given configure time feature is enabled
+#
+_require_feature()
+{
+ $BUILDCONF -c -n $1 || _notrun "feature not enabled: $1"
+}
+
_full_imgfmt_details()
{
if [ -n "$IMGOPTS" ]; then
--
2.9.4
[Qemu-devel] [PATCH 2/3] qemu-iotests: add _require_feature() function,
Cleber Rosa <=
[Qemu-devel] [PATCH 1/3] scripts: introduce buildconf.py, Cleber Rosa, 2017/07/20
Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, no-reply, 2017/07/21
Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, Stefan Hajnoczi, 2017/07/21