[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 4/8] tpm-backend: Made few interface methods
From: |
Amarnath Valluri |
Subject: |
Re: [Qemu-devel] [PATCH v6 4/8] tpm-backend: Made few interface methods optional |
Date: |
Sat, 22 Jul 2017 07:32:24 +0300 |
On Tue, 2017-07-18 at 10:15 +0000, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jul 18, 2017 at 10:48 AM Amarnath Valluri
> <address@hidden> wrote:
>
> This allows backend implementations left optional interface
> methods.
> For mandatory methods assertion checks added.
>
> Took the opportunity to remove unused methods:
> tpm_backend_get_type()
> tpm_backend_get_desc()
>
> Signed-off-by: Amarnath Valluri <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Stefan Berger<address@hidden>
> ---
> backends/tpm.c | 36
> +++++++++++++++++-------------------
> hw/tpm/tpm_passthrough.c | 23 +----------------------
> include/sysemu/tpm_backend.h | 19 +------------------
> tpm.c | 2 +-
> 4 files changed, 20 insertions(+), 60 deletions(-)
>
> LINK x86_64-softmmu/qemu-system-x86_64
> ../tpm.o: In function `qmp_query_tpm_inst':
> /home/elmarco/src/qq/tpm.c:261: undefined reference to
> `tpm_backend_get_type'
> collect2: error: ld returned 1 exit status
Thanks Marc, for pointing it out, i will this patch.
- Amarnath
- [Qemu-devel] [PATCH v6 0/8] Provide support for the software TPM emulator, Amarnath Valluri, 2017/07/18
- [Qemu-devel] [PATCH v6 3/8] tpm-backend: Initialize and free data members in it's own methods, Amarnath Valluri, 2017/07/18
- [Qemu-devel] [PATCH v6 2/8] tpm-backend: Move thread handling inside TPMBackend, Amarnath Valluri, 2017/07/18
- [Qemu-devel] [PATCH v6 6/8] tpm-backend: Move realloc_buffer() implementation to tpm-tis model, Amarnath Valluri, 2017/07/18
- [Qemu-devel] [PATCH v6 7/8] tpm-passthrough: move reusable code to utils, Amarnath Valluri, 2017/07/18