[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 32/34] target/arm: Move ss check to init_dis
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH v14 32/34] target/arm: Move ss check to init_disas_context |
Date: |
Sat, 22 Jul 2017 12:07:47 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Richard Henderson writes:
> We can check for single-step just once.
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Lluís Vilanova <address@hidden>
> ---
> target/arm/translate.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 4b1230b..ebe1c1a 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -11845,6 +11845,11 @@ static int
> arm_tr_init_disas_context(DisasContextBase *dcbase,
dc-> next_page_start =
> (dc->base.pc_first & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
> + /* If architectural single step active, limit to 1. */
> + if (is_singlestepping(dc)) {
> + max_insns = 1;
> + }
> +
> cpu_F0s = tcg_temp_new_i32();
> cpu_F1s = tcg_temp_new_i32();
> cpu_F0d = tcg_temp_new_i64();
> @@ -12000,11 +12005,9 @@ static void arm_tr_translate_insn(DisasContextBase
> *dcbase, CPUState *cpu)
> * Also stop translation when a page boundary is reached. This
> * ensures prefetch aborts occur at the right place. */
> - if (is_singlestepping(dc)) {
> - dc->base.is_jmp = DISAS_TOO_MANY;
> - } else if ((dc->pc >= dc->next_page_start) ||
> - ((dc->pc >= dc->next_page_start - 3) &&
> - insn_crosses_page(env, dc))) {
> + if (dc->pc >= dc->next_page_start ||
> + (dc->pc >= dc->next_page_start - 3 &&
> + insn_crosses_page(env, dc))) {
> /* We want to stop the TB if the next insn starts in a new page,
> * or if it spans between this page and the next. This means that
> * if we're looking at the last halfword in the page we need to
> --
> 2.9.4
- [Qemu-devel] [PATCH v14 28/34] target/arm: [tcg] Port to disas_log, (continued)
- [Qemu-devel] [PATCH v14 28/34] target/arm: [tcg] Port to disas_log, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 29/34] target/arm: [tcg, a64] Port to disas_log, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 30/34] target/arm: [tcg] Port to generic translation framework, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 31/34] target/arm: [a64] Move page and ss checks to init_disas_context, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 32/34] target/arm: Move ss check to init_disas_context, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 33/34] target/arm: Split out thumb_tr_translate_insn, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 34/34] target/arm: Perform per-insn cross-page check only for Thumb, Richard Henderson, 2017/07/15
- Re: [Qemu-devel] [PATCH v14 00/34] Generic translation framework, no-reply, 2017/07/15