|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-devel] [PATCH for 2.10 21/35] arm/sysbus-fdt: fix null pointer dereference |
Date: | Mon, 24 Jul 2017 18:48:45 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/24/2017 06:09 PM, Peter Maydell wrote:
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé <address@hidden> wrote:Use error_report() + exit() instead of error_setg(&error_fatal). hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variable 'node_path') results in a null pointer dereference if (node_path[1]) { ^~~~~~~~~~~~I don't understand what this warning is trying to say. We can't get to this point with a NULL node_path, because of the previous conditional, which is using error_setg(&error_fatal).
Ok I see, Clang is unaware than error_setg(&error_fatal) is a noreturn. Patch dropped. Thanks, Phil.
[Prev in Thread] | Current Thread | [Next in Thread] |