Re: [Qemu-devel] [PATCH 1/5] Makefile: clean: Clean exe files

[Philippe Mathieu-Daudé]

I purposed another fix for Sameeh's issue, see:
http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07597.html

On 07/25/2017 08:10 PM, Michael Roth wrote:
> Quoting Peter Maydell (2017-07-23 15:03:56)
> > On 5 July 2017 at 08:54, Sameeh Jubran <address@hidden> wrote:
> > > From: Sameeh Jubran <address@hidden>
> > >
> > > Clean exe files such as qemu-ga.exe
> > >
> > > Signed-off-by: Sameeh Jubran <address@hidden>
> > > ---
> > >   Makefile | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index 16a0430..22d29d6 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -487,6 +487,7 @@ clean:
> > >          rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h 
> > > gen-op-arm.h
> > >          rm -f qemu-options.def
> > >          rm -f *.msi
> > > +       rm -f *${EXESUF}
> >
> > On every host OS except Windows, ${EXESUF} is defined
> > to be the empty string, which means that this will be
> > "rm -f *", which is probably not what we want...
>
> Perhaps something like:
>
>    clean:
>      ...
>    ifneq ($(EXESUF),)
>      rm -f *${EXESUF}
>    endif
>
> ?
>
> > thanks
> > -- PMM