Re: [Qemu-devel] [PATCH v6 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v6 0/5] hypertrace: Lightweight guest-to-QEMU 
trace channel
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9b0cb61 hypertrace: Add guest-side user-level library
f006a56 hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event
09bbb51 hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event
6abaa06 hypertrace: Add tracing event "guest_hypertrace"
98411ea hypertrace: Add documentation

=== OUTPUT BEGIN ===
Checking PATCH 1/5: hypertrace: Add documentation...
Checking PATCH 2/5: hypertrace: Add tracing event "guest_hypertrace"...
Checking PATCH 3/5: hypertrace: [*-user] Add QEMU-side proxy to 
"guest_hypertrace" event...
ERROR: Error messages should not contain newlines
#91: FILE: bsd-user/main.c:991:
+        error_report("error: atexit: %s\n", strerror(errno));

WARNING: line over 80 characters
#295: FILE: hypertrace/common.c:30:
+    /* We need twice the number of clients (*in pages*) for the double-fault 
protocol */

WARNING: line over 80 characters
#454: FILE: hypertrace/user.c:97:
+        error_report("error: -hypertrace max-clients expects a positive 
number");

ERROR: space prohibited after that '*' (ctx:BxW)
#509: FILE: hypertrace/user.c:152:
+typedef void (* sigaction_t)(int, siginfo_t *, void *);
               ^

ERROR: Error messages should not contain newlines
#925: FILE: linux-user/main.c:4473:
+        error_report("error: atexit: %s\n", strerror(errno));

total: 3 errors, 2 warnings, 976 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/5: hypertrace: [softmmu] Add QEMU-side proxy to 
"guest_hypertrace" event...
ERROR: code indent should never use tabs
#124: FILE: hypertrace/softmmu.c:85:
+^Iabort();$

ERROR: code indent should never use tabs
#163: FILE: hypertrace/softmmu.c:124:
+^Iabort();$

total: 2 errors, 0 warnings, 259 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/5: hypertrace: Add guest-side user-level library...
WARNING: architecture specific defines should be avoided
#171: FILE: hypertrace/guest/common.c:84:
+#if !defined(CONFIG_USER_ONLY) && defined(__linux__)

ERROR: consider using qemu_strtoull in preference to strtoull
#191: FILE: hypertrace/guest/common.c:104:
+    uint64_t vv = strtoull(v, &res, 16);

total: 1 errors, 1 warnings, 432 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden