[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public |
Date: |
Thu, 27 Jul 2017 15:18:04 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Jul 25, 2017 at 07:10:09PM +0200, Amador Pahim wrote:
> Let's make args public so users can extend it in instances
> without feeling like abusing the internal API.
>
> Signed-off-by: Amador Pahim <address@hidden>
> ---
> scripts/qemu.py | 14 +++++++-------
> tests/qemu-iotests/iotests.py | 18 +++++++++---------
> 2 files changed, 16 insertions(+), 16 deletions(-)
As discussed in the previous revision, I don't think this patch is
justified because all current users just need a protected field. There
are no users who need the field to be public so this change is
premature.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups, Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public, Amador Pahim, 2017/07/25
- Re: [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v5 5/6] qemu.py: make sure shutdown() is called before launching again, Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 6/6] qemu.py: include qemu command line and output on launch error, Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code, Amador Pahim, 2017/07/25