[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] hmp, qmp: introduce memory-size-summary comm
From: |
Vadim Galitsyn |
Subject: |
Re: [Qemu-devel] [PATCH v4] hmp, qmp: introduce memory-size-summary commands |
Date: |
Fri, 28 Jul 2017 14:10:41 +0200 |
Hi Guys,
This thread is a continuation of discussion from:
http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg01565.html
I will post changes list here in cover letter.
v5:
* hmp: Updated description and '.help' message for
'info memory-size-summary' command.
* hmp: Removed '-' characters from
'info memory-size-summary' output.
* Dropped ballooned memory information.
* get_existing_hotpluggable_memory_size() assumed
to never fail; routine now has no arguments and
returns uint64_t; in case if target does not support
memory hotplug, (uint64_t)-1 is returned.
* MemoryInfo structure:
* Removed @balloon-actual-memory field.
* Field @hotpluggable-memory renamed
to @hotunpluggable-memory.
* Updated description for fields.
* qmp: Updated description for
query-memory-size-summary.
* Patch v4 splitted into series.
v4:
* Commands "info memory" and "query-memory" were renamed
to "info memory-size-summary" and "query-memory-size-summary"
correspondingly.
* Descriptions for both commands as well as MemoryInfo structure
fields were updated/renamed according to
http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05972.html.
* In MemoryInfo structure following fields are now optional:
hotpluggable-memory and balloon-actual-memory.
* Field "hotpluggable-memory" now not displayed in HMP if target
has no CONFIG_MEM_HOTPLUG enabled.
* Field "balloon-actual-memory" now not displayed in HMP if
ballooning not enabled.
* qapi_free_MemoryInfo() used in order to free corresponding memory
instead of g_free().
* #ifdef CONFIG_MEM_HOTPLUG was removed and replaced with stubs/ approach.
get_exiting_hotpluggable_memory_size() function was introduced in
hw/mem/pc-dimm.c (available for all targets which have CONFIG_MEM_HOTPLUG
enabled). For other targets, there is a stub in stubs/qmp_pc_dimm.c.
In addition, stubs/qmp_pc_dimm_device_list.c was renamed to
stubs/qmp_pc_dimm.c in order to reflect actual source file content.
* Commit message was updated in order to reflect what was changed.
v3:
* Use PRIu64 instead of 'lu' when printing results via HMP.
* Report zero hot-plugged memory instead of reporting error
when target architecture has no CONFIG_MEM_HOTPLUG enabled.
v2:
* Fixed build for targets which do not have CONFIG_MEM_HOTPLUG
enabled.
Best regards,
Vadim