qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.10 4/5] tests: acpi: add comments to fetch


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH for-2.10 4/5] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage
Date: Wed, 2 Aug 2017 16:04:03 +0300
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1

On 31/07/2017 18:40, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov <address@hidden>
---
  tests/bios-tables-test.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index ed32e9a..a2a90d7 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -251,6 +251,8 @@ static void fetch_rsdt_referenced_tables(test_data *data)
uint32_t addr = data->rsdt_tables_addr[i + 1]; /* fadt is first */
          fetch_table(&ssdt_table, addr);
+
+        /* Add table to ASL test tables list */
          g_array_append_val(data->tables, ssdt_table);
      }
  }
@@ -425,6 +427,7 @@ try_again:
      return exp_tables;
  }
+/* test the list of tables in @data->tables against reference tables */
  static void test_acpi_asl(test_data *data)
  {
      int i;



Reviewed-by: Marcel Apfelbaum <address@hidden>

Thanks,
Marcel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]