Re: [Qemu-devel] [PATCH for-2.10 5/5] tests: acpi: fix FADT not being compared to reference table

[Marcel Apfelbaum]

On 31/07/2017 18:40, Igor Mammedov wrote:
> It turns out that FADT isn't actually tested for changes
> against reference table, since it happens to be the 1st
> table in RSDT which is currently ignored.
> Fix it by making sure that all tables from RSDT are added
> to test list.

Hi Igor,

> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>   tests/bios-tables-test.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index a2a90d7..129ef46 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -243,13 +243,13 @@ static void test_acpi_dsdt_table(test_data *data)
>   /* Load all tables and add to test list directly RSDT referenced tables */
>   static void fetch_rsdt_referenced_tables(test_data *data)
>   {
> -    int tables_nr = data->rsdt_tables_nr - 1; /* fadt is first */
> +    int tables_nr = data->rsdt_tables_nr;
>       int i;
>   
>       for (i = 0; i < tables_nr; i++) {
>           AcpiSdtTable ssdt_table;
>   
> -        uint32_t addr = data->rsdt_tables_addr[i + 1]; /* fadt is first */
> +        uint32_t addr = data->rsdt_tables_addr[i];
>           fetch_table(&ssdt_table, addr);
>   
>           /* Add table to ASL test tables list */

For some reason I decided not to test it... strange.
Anyway, we should also add the expected file, right?
(the rebuild script works only for existent tables, I think)

Thanks,
Marcel