[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.10 4/4] block/vhdx: check error return
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.10 4/4] block/vhdx: check error return of bdrv_truncate() |
Date: |
Mon, 7 Aug 2017 07:55:57 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/07/2017 07:38 AM, Jeff Cody wrote:
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> block/vhdx-log.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/block/vhdx-log.c b/block/vhdx-log.c
> index a27dc05..14b724e 100644
> --- a/block/vhdx-log.c
> +++ b/block/vhdx-log.c
> @@ -558,7 +558,11 @@ static int vhdx_log_flush(BlockDriverState *bs,
> BDRVVHDXState *s,
> ret = -EINVAL;
> goto exit;
> }
> - bdrv_truncate(bs->file, new_file_size, PREALLOC_MODE_OFF,
> NULL);
> + ret = bdrv_truncate(bs->file, new_file_size,
> PREALLOC_MODE_OFF,
> + NULL);
> + if (ret < 0) {
> + goto exit;
> + }
> }
> }
> qemu_vfree(desc_entries);
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 for-2.10 0/4] VHDX bugfixes, Jeff Cody, 2017/08/07
- [Qemu-devel] [PATCH v2 for-2.10 1/4] block/vhdx: check error return of bdrv_getlength(), Jeff Cody, 2017/08/07
- [Qemu-devel] [PATCH v2 for-2.10 3/4] block/vhdx: check error return of bdrv_flush(), Jeff Cody, 2017/08/07
- [Qemu-devel] [PATCH v2 for-2.10 2/4] block/vhdx: check for offset overflow to bdrv_truncate(), Jeff Cody, 2017/08/07
- [Qemu-devel] [PATCH v2 for-2.10 4/4] block/vhdx: check error return of bdrv_truncate(), Jeff Cody, 2017/08/07
- Re: [Qemu-devel] [PATCH v2 for-2.10 4/4] block/vhdx: check error return of bdrv_truncate(),
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 for-2.10 0/4] VHDX bugfixes, Kevin Wolf, 2017/08/07