Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

[Markus Armbruster]

Pradeep Jagadeesh <address@hidden> writes:

> On 7/7/2017 8:14 AM, Markus Armbruster wrote:
>> Pradeep Jagadeesh <address@hidden> writes:
>>
>>> These patches provide the qmp interface, to query the io throttle
>>> status of the all fsdev devices that are present in a vm.
>>> also, it provides an interface to set the io throttle parameters of a
>>> fsdev to a required value. some of the patches also remove the duplicate
>>> code that was present in block and fsdev files.
>>>
>>> Pradeep Jagadeesh (6):
>>>   throttle: factor out duplicate code
>>>   qmp: Create IOThrottle structure
>>>   throttle: move out function to reuse the code
>>>   hmp: create a throttle initialization function for code reusability
>>>   fsdev: hmp interface for throttling
>>>   fsdev: QMP interface for throttling
>>>
>>>  Makefile                        |   4 ++
>>>  blockdev.c                      |  97 ++-------------------------------
>>>  fsdev/qemu-fsdev-dummy.c        |  10 ++++
>>>  fsdev/qemu-fsdev-throttle.c     | 118 
>>> ++++++++++++++++++++++++++--------------
>>>  fsdev/qemu-fsdev-throttle.h     |  13 +++++
>>>  fsdev/qemu-fsdev.c              |  37 +++++++++++++
>>>  hmp-commands-info.hx            |  18 ++++++
>>>  hmp-commands.hx                 |  19 +++++++
>>>  hmp.c                           |  81 +++++++++++++++++++++++++--
>>>  hmp.h                           |   4 ++
>>>  include/qemu/throttle-options.h |   7 +++
>>>  include/qemu/throttle.h         |   4 +-
>>>  include/qemu/typedefs.h         |   1 +
>>>  monitor.c                       |   5 ++
>>>  qapi-schema.json                |   3 +
>>>  qapi/block-core.json            |  76 +-------------------------
>>>  qapi/fsdev.json                 |  84 ++++++++++++++++++++++++++++
>>>  qapi/iothrottle.json            |  88 ++++++++++++++++++++++++++++++
>>>  qmp.c                           |  14 +++++
>>>  util/throttle.c                 | 110 +++++++++++++++++++++++++++++++++++++
>>>  20 files changed, 577 insertions(+), 216 deletions(-)
>>>  create mode 100644 qapi/fsdev.json
>>>  create mode 100644 qapi/iothrottle.json
>>
>> No test coverage?
> I wanted to upstream these first then I am planning to write the tests.

Feels backwards to me :)