[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module |
Date: |
Tue, 8 Aug 2017 09:57:06 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Aug 08, 2017 at 11:07:21AM +0100, Stefan Hajnoczi wrote:
> On Fri, Aug 04, 2017 at 06:36:21PM -0300, Eduardo Habkost wrote:
> > It makes command-line parsing and generation of help text much
> > simpler.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > scripts/qmp/qmp-shell | 61
> > +++++++++++++++++----------------------------------
> > 1 file changed, 20 insertions(+), 41 deletions(-)
>
> The minimum Python version is 2.6. The argparse module was introduced
> in Python 2.7 so we cannot use it without increasing the minimum Python
> version:
>
> https://docs.python.org/2.6/modindex.html
>
> I suggest holding off on this for now.
2.6 is the minimum Python version for what, exactly? Is it for
building QEMU?
Note that qmp-shell is a tool for developers, not required for
building or running QEMU. People who really want to run
qmp-shell on a python-2.6 system can still install argparse if
they want to use qmp-shell.
I could backport the code to optparse. But should we add code
that relies on a deprecated module, if developers running Python
2.6 can install argparse?
--
Eduardo
- [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 4/5] qmp-shell: Accept QMP command as argument, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 3/5] qmp-shell: execute_cmdargs() method, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 5/5] Remove scripts/qmp/qmp, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 2/5] qmp-shell: Pass split cmdargs to __build_cmd(), Eduardo Habkost, 2017/08/04
- Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp, Fam Zheng, 2017/08/05
- Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp, John Snow, 2017/08/07