[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/6] QEMU: kvm: cleanup kvm_slot handling
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/6] QEMU: kvm: cleanup kvm_slot handling |
Date: |
Wed, 9 Aug 2017 18:49:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 09/08/2017 15:33, David Hildenbrand wrote:
> If I am not missing something important here, we can heavily simplify
> the kvm_slot code. Flatview will make sure that we don't have to deal
> with overlapping slots. E.g. when a memory section is resized, we are
> first notified about the removal and then about the new memory section.
>
> So basically, we can directly always map one memory section to one
> kvm slot (if the fixed up size is > 0).
>
> Only very briefly tested. Will do some more testing if we agree that this
> is the right thing to do.
Yes, it all looks very sane.
Paolo
> David Hildenbrand (6):
> kvm: require JOIN_MEMORY_REGIONS_WORKS
> kvm: factor out alignment of memory section
> kvm: use start + size for memory ranges
> kvm: we never have overlapping slots in kvm_set_phys_mem()
> kvm: kvm_log_start/stop are only called with known sections
> kvm: kvm_log_sync() is only called with known memory sections
>
> accel/kvm/kvm-all.c | 276
> +++++++++++++++++-----------------------------------
> 1 file changed, 89 insertions(+), 187 deletions(-)
>
- [Qemu-devel] [PATCH RFC 0/6] QEMU: kvm: cleanup kvm_slot handling, David Hildenbrand, 2017/08/09
- [Qemu-devel] [PATCH RFC 1/6] kvm: require JOIN_MEMORY_REGIONS_WORKS, David Hildenbrand, 2017/08/09
- [Qemu-devel] [PATCH RFC 2/6] kvm: factor out alignment of memory section, David Hildenbrand, 2017/08/09
- [Qemu-devel] [PATCH RFC 4/6] kvm: we never have overlapping slots in kvm_set_phys_mem(), David Hildenbrand, 2017/08/09
- [Qemu-devel] [PATCH RFC 5/6] kvm: kvm_log_start/stop are only called with known sections, David Hildenbrand, 2017/08/09
- [Qemu-devel] [PATCH RFC 3/6] kvm: use start + size for memory ranges, David Hildenbrand, 2017/08/09
- [Qemu-devel] [PATCH RFC 6/6] kvm: kvm_log_sync() is only called with known memory sections, David Hildenbrand, 2017/08/09
- Re: [Qemu-devel] [PATCH RFC 0/6] QEMU: kvm: cleanup kvm_slot handling,
Paolo Bonzini <=