qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h
Date: Fri, 11 Aug 2017 06:15:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 08/11/2017 12:46 AM, David Hildenbrand wrote:
> +
> +static const char *cc_names[] = {
> +    [CC_OP_CONST0]    = "CC_OP_CONST0",

This should get moved out of the header to the c file that uses it.
(Why it's ever there in the first place is a mystery...)

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]