[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h
|
From: |
David Hildenbrand |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h |
|
Date: |
Fri, 11 Aug 2017 15:21:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 11.08.2017 15:15, Richard Henderson wrote:
> On 08/11/2017 12:46 AM, David Hildenbrand wrote:
>> +
>> +static const char *cc_names[] = {
>> + [CC_OP_CONST0] = "CC_OP_CONST0",
>
> This should get moved out of the header to the c file that uses it.
> (Why it's ever there in the first place is a mystery...)
>
> Otherwise,
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
>
Thanks, I'll add a separate patch for that then!
--
Thanks,
David
Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h, Thomas Huth, 2017/08/11
[Qemu-devel] [PATCH RFC 3/5] s390x: avoid calling kvm_ functions outside of target/s390x/, David Hildenbrand, 2017/08/11