[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/3] target/arm: Correct exclusive store cmpx
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/3] target/arm: Correct exclusive store cmpxchg memop mask |
Date: |
Sat, 12 Aug 2017 13:36:45 +0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Aug 11, 2017 at 03:17:41PM -0700, Alistair Francis wrote:
> When we perform the atomic_cmpxchg operation we want to perform the
> operation on a pair of 32-bit registers. Previously we were just passing
> the register size in which was set to MO_32. This would result in the
> high register to be ignored. To fix this issue we hardcode the size to
> be 64-bits long when operating on 32-bit pairs.
Good catch Alistair!
Reviewed-by: Edgar E. Iglesias <address@hidden>
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>
> This was caught with an internal fuzzy tester. These patches fix the
> Xilinx 2.10-rc2 tree. I tested with the fuzzy tester (single CPU) and
> Linux boot (4 CPUs) on the Xilinx tree. I don't have a good test case to
> run on mainline, but am working with some internal teams to get one.
> Also linux-user is fully untested.
>
> All tests were with MTTCG enabled.
>
> target/arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 245175e2f1..49b4d6918d 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -1913,7 +1913,7 @@ static void gen_store_exclusive(DisasContext *s, int
> rd, int rt, int rt2,
> tcg_gen_concat32_i64(val, cpu_exclusive_val, cpu_exclusive_high);
> tcg_gen_atomic_cmpxchg_i64(tmp, addr, val, tmp,
> get_mem_index(s),
> - size | MO_ALIGN | s->be_data);
> + MO_64 | MO_ALIGN | s->be_data);
> tcg_gen_setcond_i64(TCG_COND_NE, tmp, tmp, val);
> tcg_temp_free_i64(val);
> } else if (s->be_data == MO_LE) {
> --
> 2.11.0
>
- [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic, Alistair Francis, 2017/08/11
- [Qemu-devel] [PATCH v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions, Alistair Francis, 2017/08/11
- [Qemu-devel] [PATCH v1 1/3] target/arm: Update the memops for exclusive load, Alistair Francis, 2017/08/11
- [Qemu-devel] [PATCH v1 3/3] target/arm: Correct exclusive store cmpxchg memop mask, Alistair Francis, 2017/08/11
- Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic, Alistair Francis, 2017/08/11
- Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic, Peter Maydell, 2017/08/12