[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses |
|
Date: |
Tue, 15 Aug 2017 02:05:10 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 14/08/2017 21:03, Matt Parker wrote:
>>> static const MemoryRegionOps rtl8139_mmio_ops = {
>> I think you don't even need to declare a separate MemoryRegionOps, and
>> can just recycle rtl8139_io_ops?
> Looking at the memory region, it's only 0x100 bytes in size,
> so addr & 0xFF would not be needed.
>
> In that case your right, the bar1 memory can just reuse the MemoryRegion from
> IO.
> I'll update the patch for this.
You can reuse the MemoryRegionOps; you cannot reuse the MemoryRegion,
but you can replace memory_region_init_io with memory_region_init_alias
if you prefer.
Paolo