Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

[Philippe Mathieu-Daudé]

On 08/15/2017 03:40 PM, Eric Blake wrote:
> On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote:
> > On 08/15/2017 03:13 PM, Eric Blake wrote:
> > > On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote:
> > > > only warn once about it.
> > > >
> > > > - kernel without kvm:
> > > >
> > > >       # make check-qtest-x86_64
> > > >         GTESTER check-qtest-x86_64
> > > >       Could not access KVM kernel module: No such device
> > > >       qemu-system-x86_64: failed to initialize KVM: No such device
> > > >       qemu-system-x86_64: Back to tcg accelerator
> > >
> > > How does this differ from what commit 2f6b38d1 was trying to do?
> >
> > I'd say 2f6b38d1 is for common end-user usage while this is for
> > QA/testers usage. If you run N qtests with the same machine arguments,
> > having this warning displayed only once is enough and allow you to focus
> > on the tests output.
>
> I guess my question is: Are we still getting a warning output even with
> 2f6b38d1 applied?  If so, why, because the point of that commit was to
> avoid the warning.

The function this patch adds is called by gtester to prepare the QEMU 
command line options, usually this is done once in main(), then each 
qtest is run with the same QEMU command line.

Once started QEMU calls accel_init_machine() displaying warnings from 
303d4e865b7.

Having 3 lines of warnings for each test is way too verbose.