[Qemu-devel] Crash when deleting the diag288 watchdog

[Thomas Huth]

 Hi,

I recently noticed that QEMU abort()s if you try to remove the diag288
watchdog. For example:

$ qemu-system-s390x -nographic -nodefaults -S -monitor stdio
QEMU 2.9.92 monitor - type 'help' for more information
(qemu) device_add diag288,id=x
(qemu) device_del x
**
ERROR:/home/thuth/devel/qemu/qdev-monitor.c:872:qdev_unplug: assertion
failed: (hotplug_ctrl)
Aborted (core dumped)

This is ugly, can we fix this somehow? For example, should the diag288
device be hot-pluggable at all, or can it only be used via the
"-watchdog" parameter instead? In the latter case, we could simply mark
the device with "user_creatable = false", I guess?

 Thomas