[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation |
Date: |
Thu, 17 Aug 2017 06:54:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
John Snow <address@hidden> writes:
> On 08/14/2017 05:57 PM, Eduardo Habkost wrote:
>> Example output when using "-machine q35":
>>
>> {
>> "available": true,
>> "count": 1,
>> "device-types": [
>> "ide-device"
>> ],
>> "hotpluggable": false,
>> "opts": [
>> { "option": "unit", "values": 0 },
>> { "option": "bus", "values": "ide.2" }
>> ],
>> "opts-complete": true
>> }
>> {
>> "available": false,
>> "count": 1,
>> "device": "/machine/unattached/device[19]",
>> "device-types": [
>> "ide-device"
>> ],
>> "hotpluggable": false,
>> "opts": [
>> { "option": "unit", "values": 1 },
>> { "option": "bus", "values": "ide.2" } ],
>> "opts-complete": true
>> }
>> {
>> "available": true,
>> "count": 10,
>> "device-types": [
>> "ide-device"
>> ],
>> "hotpluggable": false,
>> "opts": [
>> { "option": "unit", "values": [ [ 0, 1 ] ] },
>
> Hm, these unit values aren't really correct -- we do not support
> primary/secondary semantics for IDE buses on the AHCI device. I guess
> they technically exist, but you cannot use them for anything.
>
> Should I do something to "disable" or otherwise hide the unusable
> secondary unit slots for AHCI devices?
I think that would make this introspection more useful.
- Re: [Qemu-devel] [RFC v4 02/13] qapi: qobject_compare() helper, (continued)
- [Qemu-devel] [RFC v4 03/13] qdev: Add BusClass::device_type field, Eduardo Habkost, 2017/08/14
- [Qemu-devel] [RFC v4 04/13] qdev: Slot info helpers, Eduardo Habkost, 2017/08/14
- [Qemu-devel] [RFC v4 05/13] query-device-slots: Collapse similar entries, Eduardo Habkost, 2017/08/14
- [Qemu-devel] [RFC v4 06/13] qdev core: generic enumerate_slots implementation, Eduardo Habkost, 2017/08/14
- [Qemu-devel] [RFC v4 07/13] qdev: Enumerate CPU slots on query-device-slots, Eduardo Habkost, 2017/08/14
- [Qemu-devel] [RFC v4 09/13] pci: pci_bus_has_pcie_upstream_port() function, Eduardo Habkost, 2017/08/14
- [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation, Eduardo Habkost, 2017/08/14
[Qemu-devel] [RFC v4 10/13] pci: device-number & function properties, Eduardo Habkost, 2017/08/14
[Qemu-devel] [RFC v4 11/13] pci: enumerate_slots implementation, Eduardo Habkost, 2017/08/14
[Qemu-devel] [RFC v4 12/13] usb: enumerate_slots implementation, Eduardo Habkost, 2017/08/14
[Qemu-devel] [RFC v4 13/13] tests: Experimental query-device-slots test code, Eduardo Habkost, 2017/08/14
Re: [Qemu-devel] [libvirt] [RFC v4 00/13] qmp: query-device-slots command, no-reply, 2017/08/14