[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib |
Date: |
Thu, 17 Aug 2017 14:25:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 17/08/2017 14:21, Stefan Hajnoczi wrote:
>> + guest = QEMUMachine(binary=os.environ.get("QEMU",
>> "qemu-system-x86_64"),
>> + args=args)
>> + guest._vga = "std"
> _vga is a protected field. We don't inherit from QEMUMachine so it
> shouldn't be accessed directly. One option is to add a vga argument to
> the QEMUMachine() constructor.
You can just use "-device VGA" here, since this code is x86-specific.
"-vga none -device VGA" works well, so patch 2 can be dropped.
Paolo
- [Qemu-devel] [PATCH RFC v2 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux), Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 01/10] gitignore: Ignore vm test images, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 02/10] qemu.py: Add variable vga type, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 03/10] qemu.py: Add "wait()" method, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 05/10] tests: Add ubuntu.i386 image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 06/10] tests: Add FreeBSD image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 07/10] tests: Add NetBSD image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 08/10] tests: Add OpenBSD image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 09/10] Makefile: Add rules to run vm tests, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC v2 10/10] MAINTAINERS: Add tests/vm entry, Fam Zheng, 2017/08/16
- Re: [Qemu-devel] [PATCH RFC v2 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux), no-reply, 2017/08/16