[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of syse
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files |
Date: |
Mon, 21 Aug 2017 12:50:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 21.08.2017 11:52, Cornelia Huck wrote:
> On Fri, 18 Aug 2017 19:28:34 +0200
> David Hildenbrand <address@hidden> wrote:
>
>> On 18.08.2017 18:08, Thomas Huth wrote:
>>> On 18.08.2017 13:43, David Hildenbrand wrote:
>>>> s390-stattrib.c needs definition of TARGET_PAGE_SIZE, solve it via cpu.h.
>>>
>>> Why not simply #include "exec/cpu-all.h" ? If cpu.h is not really needed
>>> here...
>>>
>>> Thomas
>>>
>>>
>>
>> Git grep showed me that this is a very rare thing to do, so I went for
>> cpu.h. If you prefer cpu-all.h, I can use that.
>
> Is there any target that does not include cpu-all.h in its cpu.h? We
> probably can remove all includes of cpu-all.h in .c files, as all of
> them include cpu.h as well...
>
I guess they have to, otherwise this stuff will not compile.
Yes, we should be able to remove exec/cpu-all.h from both remaining
users, dump.c and exec.c, as they already include cpu.h as you also noticed.
--
Thanks,
David
- [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed(), (continued)
[Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h, David Hildenbrand, 2017/08/18
Re: [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h, Cornelia Huck, 2017/08/21
[Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 12/18] target/s390x: move s390_do_cpu_reset() to diag.c, David Hildenbrand, 2017/08/18