[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/15] ppc4xx: Export ECB and PLB emulation
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 12/15] ppc4xx: Export ECB and PLB emulation |
Date: |
Wed, 23 Aug 2017 12:30:24 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote:
> Make these device models available outside ppc405_uc.c for reuse in
> 460EX emulation. They are left in their current place for now because
> they are used mostly unchanged and I'm not sure these correctly model
> the components in 440 SoCs (but they seem to be good enough). These
> functions could be moved in a subsequent clean up series when this is
> confirmed.
Your reasoning convinces me. Applied to ppc-for-2.11.
>
> Signed-off-by: BALATON Zoltan <address@hidden>
> ---
> hw/ppc/ppc405.h | 3 +++
> hw/ppc/ppc405_uc.c | 4 ++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h
> index a9ffc87..7ed25cf 100644
> --- a/hw/ppc/ppc405.h
> +++ b/hw/ppc/ppc405.h
> @@ -59,6 +59,9 @@ struct ppc4xx_bd_info_t {
> ram_addr_t ppc405_set_bootinfo (CPUPPCState *env, ppc4xx_bd_info_t *bd,
> uint32_t flags);
>
> +void ppc4xx_plb_init(CPUPPCState *env);
> +void ppc405_ebc_init(CPUPPCState *env);
> +
> CPUPPCState *ppc405cr_init(MemoryRegion *address_space_mem,
> MemoryRegion ram_memories[4],
> hwaddr ram_bases[4],
> diff --git a/hw/ppc/ppc405_uc.c b/hw/ppc/ppc405_uc.c
> index 8f44cb4..e621d0a 100644
> --- a/hw/ppc/ppc405_uc.c
> +++ b/hw/ppc/ppc405_uc.c
> @@ -174,7 +174,7 @@ static void ppc4xx_plb_reset (void *opaque)
> plb->besr = 0x00000000;
> }
>
> -static void ppc4xx_plb_init(CPUPPCState *env)
> +void ppc4xx_plb_init(CPUPPCState *env)
> {
> ppc4xx_plb_t *plb;
>
> @@ -585,7 +585,7 @@ static void ebc_reset (void *opaque)
> ebc->cfg = 0x80400000;
> }
>
> -static void ppc405_ebc_init(CPUPPCState *env)
> +void ppc405_ebc_init(CPUPPCState *env)
> {
> ppc4xx_ebc_t *ebc;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 00/15] Sam460ex emulation, BALATON Zoltan, 2017/08/20
- [Qemu-devel] [PATCH 04/15] ehci: Add ppc4xx-ehci for the USB 2.0 controller in embedded PPC SoCs, BALATON Zoltan, 2017/08/20
- [Qemu-devel] [PATCH 12/15] ppc4xx: Export ECB and PLB emulation, BALATON Zoltan, 2017/08/20
- Re: [Qemu-devel] [PATCH 12/15] ppc4xx: Export ECB and PLB emulation,
David Gibson <=
- [Qemu-devel] [PATCH 02/15] ppc4xx: Make MAL emulation more generic, BALATON Zoltan, 2017/08/20
- [Qemu-devel] [PATCH 06/15] ppc4xx_i2c: QOMify, BALATON Zoltan, 2017/08/20
- [Qemu-devel] [PATCH 11/15] ppc: Add 460EX embedded CPU, BALATON Zoltan, 2017/08/20
- [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers, BALATON Zoltan, 2017/08/20