qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a G


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule
Date: Wed, 23 Aug 2017 16:45:36 +0200

  Hi,
 
> > +(cd $source_path && git submodule update --init ui/keycodemapdb)
> > +
> 
> Urgh, no, this won't work because of course you don't have to
> have a git checkout when running configure.
> 
> Any suggestions on the "best" way to ensure that the ui/keycodemapdb
> git submodule is always checked out, without requiring developers to
> do something manually ?

Don't require it?

The updates shouldn't happen that frequently, IMO we should just commit
the generated files so checking out the submodule is only needed if you
work on the keycodemaps.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]