[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11] hw/s390x/s390-skeys: Mark the storage
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11] hw/s390x/s390-skeys: Mark the storage key devices with user_creatable = false |
Date: |
Thu, 24 Aug 2017 13:28:55 +0200 |
On Thu, 24 Aug 2017 12:08:48 +0200
Thomas Huth <address@hidden> wrote:
> QEMU currently aborts if the user tries to create a skey device:
>
> $ s390x-softmmu/qemu-system-s390x -nographic -device s390-skeys-qemu
> qemu-system-s390x: hw/s390x/s390-skeys.c:30: s390_get_skeys_device:
> Assertion `ss' failed.
> Aborted (core dumped)
>
> The storage key devices are only meant to be instantiated one time,
> internally. They can not be used by the user, so mark them with
> user_creatable = false.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/s390x/s390-skeys-kvm.c | 4 ++++
> hw/s390x/s390-skeys.c | 4 ++++
> 2 files changed, 8 insertions(+)
Thanks, applied.