[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take cons
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments |
Date: |
Fri, 25 Aug 2017 08:56:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> include/qapi/qmp/qlit.h | 2 +-
> qobject/qlit.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
> index 2e22d0f73c..8882016199 100644
> --- a/include/qapi/qmp/qlit.h
> +++ b/include/qapi/qmp/qlit.h
> @@ -44,6 +44,6 @@ struct QLitDictEntry {
> #define QLIT_QLIST(val) \
> { .type = QTYPE_QLIST, .value.qlist = (val) }
>
> -bool qlit_equal_qobject(QLitObject *lhs, QObject *rhs);
> +bool qlit_equal_qobject(const QLitObject *lhs, const QObject *rhs);
>
> #endif /* QLIT_H_ */
> diff --git a/qobject/qlit.c b/qobject/qlit.c
> index a2975bef3f..ae2787ef35 100644
> --- a/qobject/qlit.c
> +++ b/qobject/qlit.c
> @@ -41,7 +41,7 @@ static void compare_helper(QObject *obj, void *opaque)
> qlit_equal_qobject(&helper->objs[helper->index++], obj);
> }
>
> -bool qlit_equal_qobject(QLitObject *lhs, QObject *rhs)
> +bool qlit_equal_qobject(const QLitObject *lhs, const QObject *rhs)
> {
> int64_t val;
Could be squashed into the previous patch, but since you got the two
split, let's leave them split and save us the trouble of wording the
squash's commit message.
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast, (continued)
- [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 06/14] qlit: make qlit_equal_qobject return a bool, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 08/14] qlit: add QLIT_QNULL and QLIT_BOOL, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments, Marc-André Lureau, 2017/08/24
- Re: [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments,
Markus Armbruster <=
- [Qemu-devel] [PATCH 09/14] qlit: replace assert(qnum_get_try_int), Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 11/14] qlit: improve QLit dict vs qdict comparison, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 10/14] tests: add qlit tests, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 12/14] qlit: improve QLit list vs qlist comparison, Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 13/14] qlit: add qobject_form_qlit(), Marc-André Lureau, 2017/08/24
- [Qemu-devel] [PATCH 14/14] qapi: generate a literal qobject for introspection, Marc-André Lureau, 2017/08/24