[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile |
Date: |
Tue, 29 Aug 2017 15:17:25 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 08/28/2017 09:41 AM, Cédric Le Goater wrote:
> On 08/23/2017 01:53 PM, Dr. David Alan Gilbert wrote:
>> * Juan Quintela (address@hidden) wrote:
>>> Compiler gets confused with the size of the struct, so move form
>>> g_new0() to g_malloc0().
>>>
>>> I *think* that the problem is in gcc (or glib for that matter), but
>>> the documentation of the g_new0 states that 1sts first argument is an
>>> struct type, and uint32_t is not an struct type.
>>>
>>> Signed-off-by: Juan Quintela <address@hidden>
>>> ---
>>>
>>> /* get the addresses of the tables pointed by rsdt */
>>> - tables = g_new0(uint32_t, tables_nr);
>>> + tables = g_malloc0(sizeof(uint32_t) * tables_nr);
>>
> I fixed that one with :
>
> @@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(void)
> AcpiRsdpDescriptor rsdp_table;
> uint32_t rsdt;
> AcpiRsdtDescriptorRev1 rsdt_table;
> - int tables_nr;
> + uint32_t tables_nr;
I like this one better (multiplication in g_malloc0() makes me worry
about overflow; using unsigned math to avoid the problem is nicer). Are
we going to see a v2 of this patch series?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 1/2] tests: Use real size for iov tests, Juan Quintela, 2017/08/23