[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] scsi, file-posix: add suppor
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management |
Date: |
Wed, 30 Aug 2017 15:26:15 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Aug 22, 2017 at 03:18:28PM +0200, Paolo Bonzini wrote:
> +#ifdef CONFIG_LINUX
> +PRManager *pr_manager_lookup(const char *id, Error **errp);
> +#else
> +static inline PRManager *pr_manager_lookup(const char *id,
> + Error **errp)
Indentation
> diff --git a/scsi/pr-manager.c b/scsi/pr-manager.c
> new file mode 100644
> index 0000000000..e80f8d9b31
> --- /dev/null
> +++ b/scsi/pr-manager.c
> @@ -0,0 +1,109 @@
> +/*
> + * Persistent reservation manager abstract class
> + *
> + * Copyright (c) 2017 Red Hat, Inc.
> + *
> + * Author: Paolo Bonzini <address@hidden>
> + *
> + * This code is licensed under the LGPL.
> + *
> + */
> +
> +#include "qemu/osdep.h"
> +#include "qapi/error.h"
> +#include "block/aio.h"
> +#include "block/thread-pool.h"
> +#include "scsi/pr-manager.h"
> +#include "scsi/trace.h"
> +
> +#include <scsi/sg.h>
HACKING "1.2. Include directives" defines the order of #includes. It
should be "qemu/osdep.h", <scsi/sg.h>, followed by all other QEMU
headers.
- Re: [Qemu-devel] [PATCH 05/10] scsi: move block/scsi.h to include/scsi/constants.h, (continued)
- [Qemu-devel] [PATCH 02/10] scsi: move non-emulation specific code to scsi/, Paolo Bonzini, 2017/08/22
- [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Paolo Bonzini, 2017/08/22
- Re: [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Fam Zheng, 2017/08/23
- Re: [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Eric Blake, 2017/08/24
- Re: [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Daniel P. Berrange, 2017/08/30
- Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 07/10] io: add qio_channel_read/write_all, Paolo Bonzini, 2017/08/22
- [Qemu-devel] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper, Paolo Bonzini, 2017/08/22