[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page tracking
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page tracking |
Date: |
Thu, 31 Aug 2017 09:20:15 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Aug 30, 2017 at 03:26:59AM -0500, Sergio Andres Gomez Del Real wrote:
> +static void hvf_log_start(MemoryListener *listener,
> + MemoryRegionSection *section, int old, int new)
> +{
> + if (old != 0)
> + return;
QEMU coding style uses curly braces even when the if statement body only
has 1 line.
> +
> + hvf_set_dirty_tracking(section, 1);
> +}
> +
> +static void hvf_log_stop(MemoryListener *listener,
> + MemoryRegionSection *section, int old, int new)
> +{
> + if (new != 0)
> + return;
Same here.
- [Qemu-devel] [PATCH v2 03/13] hvf: add compilation rules to Makefile.objs, (continued)
- [Qemu-devel] [PATCH v2 03/13] hvf: add compilation rules to Makefile.objs, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 07/13] apic: add function to apic that will be used by hvf, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 08/13] hvf: implement hvf_get_supported_cpuid, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 06/13] hvf: use new helper functions for put/get xsave, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 05/13] hvf: add fields to CPUState and CPUX86State; add definitions, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page tracking, Sergio Andres Gomez Del Real, 2017/08/30
- Re: [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page tracking,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v2 09/13] hvf: refactor cpuid code, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 13/13] hvf: inject General Protection Fault when vmexit through vmcall, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 12/13] hvf: refactor event injection code for hvf, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 11/13] hvf: move fields from CPUState to CPUX86State, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 04/13] hvf: run hvf code through checkpatch.pl and fix style issues, Sergio Andres Gomez Del Real, 2017/08/30
- [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository, Sergio Andres Gomez Del Real, 2017/08/30