[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning
From: |
Pranith Kumar |
Subject: |
Re: [Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning |
Date: |
Thu, 31 Aug 2017 12:56:45 -0400 |
CC'ing stable for 2.10.
On Tue, Aug 29, 2017 at 1:32 PM, Pranith Kumar <address@hidden> wrote:
> Fix the following warning:
>
> /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is
> only applied to the left hand side of this bitwise operator
> [-Wlogical-not-parentheses]
> if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
> ^ ~
> /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses
> after the '!' to evaluate the bitwise operator first
> if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
> ^
> /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses
> around left hand side expression to silence this warning
> if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
> ^
>
> Signed-off-by: Pranith Kumar <address@hidden>
> ---
> hw/intc/arm_gicv3_kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
> index 6051c77705..481fe5405a 100644
> --- a/hw/intc/arm_gicv3_kvm.c
> +++ b/hw/intc/arm_gicv3_kvm.c
> @@ -293,7 +293,7 @@ static void kvm_arm_gicv3_put(GICv3State *s)
> kvm_gicr_access(s, GICR_PROPBASER + 4, ncpu, ®h, true);
>
> reg64 = c->gicr_pendbaser;
> - if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
> + if (!(c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS)) {
> /* Setting PTZ is advised if LPIs are disabled, to reduce
> * GIC initialization time.
> */
> --
> 2.11.0
>
--
Pranith