[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode' |
Date: |
Fri, 1 Sep 2017 13:28:26 +0200 |
The 'returncode' Popen attribute is not guaranteed to be updated. It
actually depends on a call to either poll(), wait() or communicate().
On the other hand, poll() will: "Check if child process has terminated.
Set and return returncode attribute."
Let's use the poll() to check whether the process is running and to get
the updated process exit code, when the process is finished.
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index ede734328b..87a2212b77 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -102,12 +102,12 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen is not None and self._popen.returncode is None
+ return self._popen is not None and self._popen.poll() is None
def exitcode(self):
if self._popen is None:
return None
- return self._popen.returncode
+ return self._popen.poll()
def get_pid(self):
if not self.is_running():
--
2.13.5
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, (continued)
[Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error, Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup, Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown(), Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch(), Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode',
Amador Pahim <=
[Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again before shutdown(), Amador Pahim, 2017/09/01
Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups, Stefan Hajnoczi, 2017/09/05
Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups, Eduardo Habkost, 2017/09/14