Re: [Qemu-devel] [PULL v2 00/47] QAPI patches for 2017-09-01

[Peter Maydell]

On 1 September 2017 at 16:37, Markus Armbruster <address@hidden> wrote:
> The following changes since commit 223cd0e13f2e46078d7b573f0b8402bfbee339be:
>
>   Merge remote-tracking branch 'remotes/elmarco/tags/tidy-pull-request' into 
> staging (2017-08-31 15:52:43 +0100)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-09-01-v2
>
> for you to fetch changes up to fcff1e3146d4b7930f3b4a7a60091479d6652a5f:
>
>   qapi: drop the sentinel in enum array (2017-09-01 17:26:24 +0200)
>
> ----------------------------------------------------------------
> QAPI patches for 2017-09-01
>
> ----------------------------------------------------------------

Hi -- I get some compile issues here:

PPC:

/home/pm215/qemu/tests/qmp-test.c: In function ‘query_error_class’:
/home/pm215/qemu/tests/qmp-test.c:141:9: error: missing braces around
initializer [-Werror=missing-braces]
         "query-spice", ERROR_CLASS_COMMAND_NOT_FOUND,
         ^
/home/pm215/qemu/tests/qmp-test.c:141:9: error: (near initialization
for ‘fails[0]’) [-Werror=missing-braces]

S390, aarch64:

/home/linux1/qemu/tests/qmp-test.c: In function ‘query_error_class’:
/home/linux1/qemu/tests/qmp-test.c:151:9: error: missing braces around
initializer [-Werror=missing-braces]
         { "query-acpi-ospm-status", ERROR_CLASS_GENERIC_ERROR },
         ^
/home/linux1/qemu/tests/qmp-test.c:151:9: note: (near initialization
for ‘fails[1]’)
/home/linux1/qemu/tests/qmp-test.c:152:9: error: missing braces around
initializer [-Werror=missing-braces]
         { "query-balloon", ERROR_CLASS_DEVICE_NOT_ACTIVE },
         ^
/home/linux1/qemu/tests/qmp-test.c:152:9: note: (near initialization
for ‘fails[2]’)
/home/linux1/qemu/tests/qmp-test.c:153:9: error: missing braces around
initializer [-Werror=missing-braces]
         { "query-hotpluggable-cpus", ERROR_CLASS_GENERIC_ERROR },
         ^
/home/linux1/qemu/tests/qmp-test.c:153:9: note: (near initialization
for ‘fails[3]’)
/home/linux1/qemu/tests/qmp-test.c:154:9: error: missing braces around
initializer [-Werror=missing-braces]
         { "query-vm-generation-id", ERROR_CLASS_GENERIC_ERROR },
         ^
/home/linux1/qemu/tests/qmp-test.c:154:9: note: (near initialization
for ‘fails[4]’)
/home/linux1/qemu/tests/qmp-test.c:155:9: error: missing braces around
initializer [-Werror=missing-braces]
         { NULL, -1 }
         ^
/home/linux1/qemu/tests/qmp-test.c:155:9: note: (near initialization
for ‘fails[5]’)
/home/linux1/qemu/tests/qmp-test.c:138:17: error: missing braces
around initializer [-Werror=missing-braces]
     } fails[] = {
                 ^
/home/linux1/qemu/tests/qmp-test.c:138:17: note: (near initialization
for ‘fails’)
cc1: all warnings being treated as errors


OSX, FreeBSD, OpenBSD:

/Users/pm215/src/qemu-for-merges/tests/qmp-test.c:141:9: error:
suggest braces around initialization of subobject
[-Werror,-Wmissing-braces]
        "query-spice", ERROR_CLASS_COMMAND_NOT_FOUND,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        {                                           }

thanks
-- PMM