Re: [Qemu-devel] [PATCH v6 01/29] tests: Improve .gitignore for tests/multiboot

[Thomas Huth]

On 01.09.2017 20:03, Eric Blake wrote:
> Right now, tests/multiboot is not run by default during 'make check';
> but when it is run in-tree, it was leaving some junk behind that could
> accidentally get checked in with a careless 'git add tests'.
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  tests/.gitignore | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/.gitignore b/tests/.gitignore
> index fed0189a5a..64ecd6683b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -10,6 +10,8 @@ check-qnull
>  check-qstring
>  check-qom-interface
>  check-qom-proplist
> +multiboot/test.out

Your patch is of course a good idea ... but that test.out smells quite
bad ... I guess it should (a) use mktemp for a better file name instead
so that we can run this in parallel and (b) clean up the temporary file
once the test has been done?

> +multiboot/*.elf
>  qht-bench
>  rcutorture
>  test-aio
> 

 Thomas