qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_par


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_parse_cpu_model()
Date: Mon, 4 Sep 2017 12:03:09 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

Hi Igor,

On 09/04/2017 11:00 AM, Igor Mammedov wrote:
function not just parses features but also converts CPU model
name to CPU type, rename it to reflect what it actualy does.

Why not squash this with your 1st patch "split cpu_generic_init()"?


Signed-off-by: Igor Mammedov <address@hidden>
---
  include/qom/cpu.h | 4 ++--
  qom/cpu.c         | 4 ++--
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 392ae75..a718daf 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -643,7 +643,7 @@ ObjectClass *cpu_class_by_name(const char *typename, const 
char *cpu_model);
  CPUState *cpu_create(const char *typename);
/**
- * cpu_parse_features:
+ * cpu_parse_cpu_model:
   * @typename: The CPU base type or CPU type.
   * @cpu_model: The model string including optional parameters.
   *
@@ -652,7 +652,7 @@ CPUState *cpu_create(const char *typename);
   * Returns: type of CPU to create or prints error and terminates process
   *          if an error occurred.
   */
-const char *cpu_parse_features(const char *typename, const char *cpu_model);
+const char *cpu_parse_cpu_model(const char *typename, const char *cpu_model);
/**
   * cpu_generic_init:
diff --git a/qom/cpu.c b/qom/cpu.c
index 307d638..199ad57 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -66,7 +66,7 @@ CPUState *cpu_create(const char *typename)
      return cpu;
  }
-const char *cpu_parse_features(const char *typename, const char *cpu_model)
+const char *cpu_parse_cpu_model(const char *typename, const char *cpu_model)
  {
      ObjectClass *oc;
      CPUClass *cc;
@@ -99,7 +99,7 @@ CPUState *cpu_generic_init(const char *typename, const char 
*cpu_model)
      /* TODO: all callers of cpu_generic_init() need to be converted to
       * call cpu_parse_features() only once, before calling cpu_generic_init().
       */
-    const char *cpu_type = cpu_parse_features(typename, cpu_model);
+    const char *cpu_type = cpu_parse_cpu_model(typename, cpu_model);
assert(cpu_type);
      return cpu_create(cpu_type);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]