Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

[Pradeep Jagadeesh]

On 9/5/2017 11:34 AM, Alberto Garcia wrote:
> On Tue 05 Sep 2017 11:13:09 AM CEST, Pradeep Jagadeesh wrote:
> > > a) Declare an Error, pass it _and then handle it_ (if you don't
> > >    handle it, you're leaking it):
> > >
> > > Here you have no other way to know if qmp_query_fsdev_io_throttle()
> > > fails, so you should choose (a).
> > OK, I will pass NULL.
>
> :-)
>
> (it's ok I guess, I don't see how that function can ever be made to fail
> in the future)
:) Agreed.

-Pradeep

> Berto