qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to int


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c
Date: Tue, 5 Sep 2017 14:38:01 +0200

On Mon,  4 Sep 2017 17:43:05 +0200
David Hildenbrand <address@hidden> wrote:

> Fix up includes and rename it to s390x_*.

I'm not quite sure whether that is the right direction: servc is just an
instruction that does something and then happens to also generate an
interrupt on conclusion. I'll think a bit more about it.

> cpu.h is now free of externally implemented functions.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  hw/s390x/sclp.c            | 51 
> +---------------------------------------------
>  include/hw/s390x/sclp.h    |  1 +
>  target/s390x/cpu.h         |  5 +----
>  target/s390x/interrupt.c   | 49 ++++++++++++++++++++++++++++++++++++++++++++
>  target/s390x/kvm.c         |  2 +-
>  target/s390x/misc_helper.c |  2 +-
>  6 files changed, 54 insertions(+), 56 deletions(-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]