[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] watchdog: Allow setting action on the fl
|
From: |
Michal Privoznik |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] watchdog: Allow setting action on the fly |
|
Date: |
Wed, 6 Sep 2017 11:20:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/06/2017 11:04 AM, Daniel P. Berrange wrote:
> On Wed, Sep 06, 2017 at 10:58:54AM +0200, Michal Privoznik wrote:
>> Currently, the only time that users can set watchdog action is at
>> the start as all we expose is this -watchdog-action command line
>> argument. This is suboptimal when users want to plug the device
>> later via monitor. Alternatively, they might want to change the
>> action for already existing device on the fly.
>>
>> At the same time, drop local redefinition of the actions enum in
>> watchdog.h in favour of the ones defined in schema and thus kills
>> code duplication.
>
> Nit-pick - I'd suggest 2 separat patches - one that drops the enum
> redefinition, and the second which adds the new monitor command.
> That way you separate no-op refactoring, from new features.
Sure. We prefer that in libvirt too. Let me respin v4.
Michal