|
From: | Cornelia Huck |
Subject: | Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly |
Date: | Thu, 7 Sep 2017 15:11:07 +0200 |
On Thu, 7 Sep 2017 14:41:21 +0200 David Hildenbrand <address@hidden> wrote: > On 07.09.2017 07:46, Thomas Huth wrote: > >> #include "qemu/cutils.h" > >> #include "cpu.h" > >> -#include "exec/exec-all.h" > > You should maybe mention exec-all.h in the patch description, too. > > (I think it can be dropped here because it is included by > > translate-all.h already). > > > > If you tweak the patch description: > > Reviewed-by: Thomas Huth <address@hidden> > > I'll just drop that hunk although it can also be removed. > > Yes, this was not included on purpose - these similar names still > confuse me :) > Not only you :) If we can do a sweep of exec-all.h as well, it should be a separate patch.
[Prev in Thread] | Current Thread | [Next in Thread] |