Re: [Qemu-devel] [PATCH 1/9] buildsys: Move gtk/vte cflags/libs to per object

[Peter Maydell]

On 7 September 2017 at 18:45, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 09/07/2017 05:29 AM, Fam Zheng wrote:
>> diff --git a/ui/Makefile.objs b/ui/Makefile.objs
>> index 3369451285..146a8ce062 100644
>> --- a/ui/Makefile.objs
>> +++ b/ui/Makefile.objs
>> @@ -45,6 +45,10 @@ gtk.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)
>>   gtk-egl.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)
>>   gtk-gl-area.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)
>>   +gtk.o-libs := $(GTK_LIBS) $(VTE_LIBS)
>> +gtk-egl.o-libs := $(GTK_LIBS) $(VTE_LIBS)
>> +gtk-gl-area.o-libs := $(GTK_LIBS) $(VTE_LIBS)
>
>
> $(foreach x, gtk gtk-egl gtk-gl-area, \
>     $(eval $x.o-libs += $(GTK_LIBS) $(VTE_LIBS)) \
>     $(eval $x.o-cflags += $(GTK_CFLAGS) $(VTE_CFLAGS)) \
>
> )

I think that's worse, personally. Most developers don't
touch the makefiles very often and so doing the simple
straightforward thing is better. Then it's clearer to
people who come along later how they need to add a new
file to the makefiles (a surprisingly common question).

thanks
-- PMM