[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 17/29] ahci-test: Drop dependence on global_q
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 17/29] ahci-test: Drop dependence on global_qtest |
Date: |
Thu, 7 Sep 2017 15:19:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/05/2017 05:32 AM, Thomas Huth wrote:
> On 01.09.2017 20:03, Eric Blake wrote:
>> Managing parallel connections to two different monitors via
>> the implicit global_qtest makes it hard to copy-and-paste code
>> to tests that are not aware of the implicit state; the
>> management of global_qtest is even harder to follow because
>> it was masked behind set_context().
>>
>> ---
>> tests/libqos/libqos.h | 1 -
>> tests/ahci-test.c | 83
>> +++++++++++++++++++++++-------------------------
>> tests/libqos/ahci.c | 45 +++++++++++++-------------
>> tests/libqos/libqos-pc.c | 2 +-
>> tests/libqos/libqos.c | 37 ++++++---------------
>> 5 files changed, 73 insertions(+), 95 deletions(-)
>
> Might be easier to review if you'd split the changes to libqos.c into a
> separate patch. But anyway:
>
> Reviewed-by: Thomas Huth <address@hidden>
I'll split it, even though it means dropping R-b on both halves of the
split (so you can make sure the pieces still look sane).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 25/29] wdt_ib700-test: Drop dependence on global_qtest, (continued)
- [Qemu-devel] [PATCH v6 25/29] wdt_ib700-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 22/29] tests/boot-sector: Drop dependence on global_qtest, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 21/29] qmp-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 17/29] ahci-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 23/29] tests/acpi-utils: Drop dependence on global_qtest, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 24/29] bios-tables-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
- [Qemu-devel] [PATCH v6 16/29] libqos: Use explicit QTestState for virtio operations, Eric Blake, 2017/09/01