[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/3] backup: Adds Backup Tool
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/3] backup: Adds Backup Tool |
Date: |
Mon, 11 Sep 2017 13:02:00 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, 09/08 22:11, Ishani Chugh wrote:
> +def build_parser():
> + backup_tool = BackupTool()
> + parser = ArgumentParser()
> + subparsers = parser.add_subparsers(title='Subcommands',
> + description='Valid Subcommands',
> + help='Subcommand help')
> + guest_parser = subparsers.add_parser('guest', help='Manage guest(s)')
> + guest_subparsers = guest_parser.add_subparsers(title='Guest Subparser')
> +# Guest list
Odd indentation of comments. Please align the # at 4th colume line other code
lines. The same to below.
> + guest_list_parser = guest_subparsers.add_parser('list',
> + help='Lists all guests')
> + guest_list_parser.set_defaults(func=backup_tool.list)
> +
> +# Guest add
> + guest_add_parser = guest_subparsers.add_parser('add', help='Adds a
> guest')
> + guest_add_required = guest_add_parser.add_argument_group('Required \
> + Arguments')
> + guest_add_required.add_argument('--guest', action='store', type=str,
> + help='Name of the guest', required=True)
> + guest_add_required.add_argument('--qmp', action='store', type=str,
> + help='Path of socket', required=True)
> + guest_add_parser.set_defaults(func=backup_tool.guest_add_wrapper)
> +
> +# Guest Remove
> + guest_remove_parser = guest_subparsers.add_parser('remove',
> + help='Removes a guest')
> + guest_remove_required = guest_remove_parser.add_argument_group('Required
> \
> +
> Arguments')
> + guest_remove_required.add_argument('--guest', action='store', type=str,
> + help='Name of the guest',
> required=True)
> + guest_remove_parser.set_defaults(func=backup_tool.guest_remove_wrapper)
> +
> + drive_parser = subparsers.add_parser('drive',
> + help='Adds drive(s) for backup')
> + drive_subparsers = drive_parser.add_subparsers(title='Add subparser',
> + description='Drive \
> + subparser')
> +# Drive Add
> + drive_add_parser = drive_subparsers.add_parser('add',
> + help='Adds new \
> + drive for backup')
> + drive_add_required = drive_add_parser.add_argument_group('Required \
> + Arguments')
> + drive_add_required.add_argument('--guest', action='store', type=str,
> + help='Name of the guest', required=True)
> + drive_add_required.add_argument('--id', action='store',
> + type=str, help='Drive ID', required=True)
> + drive_add_parser.add_argument('--target', nargs='?',
> + default=None, help='Destination path')
> + drive_add_parser.set_defaults(func=backup_tool.drive_add_wrapper)
> +
> + backup_parser = subparsers.add_parser('backup', help='Creates backup')
> +
> +# Backup
> + backup_parser_required = backup_parser.add_argument_group('Required \
> + Arguments')
> + backup_parser_required.add_argument('--guest', action='store', type=str,
> + help='Name of the guest',
> + required=True)
> + backup_parser.set_defaults(func=backup_tool.fullbackup_wrapper)
> +
> +# Restore
> + restore_parser = subparsers.add_parser('restore', help='Restores drives')
> + restore_parser_required = restore_parser.add_argument_group('Required \
> + Arguments')
> + restore_parser_required.add_argument('--guest', action='store',
> + type=str, help='Name of the guest',
> + required=True)
> + restore_parser.set_defaults(func=backup_tool.restore_wrapper)
> +
> + return parser
> +
> +
> +def main():
> + parser = build_parser()
> + args = parser.parse_args()
> + args.func(args)
> +
> +if __name__ == '__main__':
> + main()
> --
> 2.7.4
>
Fam