Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

[Stefan Weil]

Am 11.09.2017 um 04:28 schrieb Philippe Mathieu-Daudé:
> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter:
> 
> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ 
> used but never defined [-Werror]
>  static bool tcg_out_ldst_finalize(TCGContext *s);
>               ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> see https://travis-ci.org/qemu/qemu/jobs/273351287
> 
>  tcg/tci/tcg-target.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
> index 5d692e1f4b..26140d78cb 100644
> --- a/tcg/tci/tcg-target.h
> +++ b/tcg/tci/tcg-target.h
> @@ -206,8 +206,4 @@ static inline void tb_target_set_jmp_target(uintptr_t 
> tc_ptr,
>      /* no need to flush icache explicitly */
>  }
>  
> -#ifdef CONFIG_SOFTMMU
> -#define TCG_TARGET_NEED_LDST_LABELS
> -#endif
> -
>  #endif /* TCG_TARGET_H */
> 

Reviewed-by: Stefan Weil <address@hidden>

Thank you.

Stefan