[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32 |
|
Date: |
Mon, 11 Sep 2017 21:17:39 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote:
> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>
> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
> qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not
> expecting: sizeof(*(uint64_t *)jmp_addr) > ATOMIC_REG_SIZE"
> QEMU_BUILD_BUG_ON(sizeof(*ptr) > ATOMIC_REG_SIZE); \
> ^
> qemu/tcg/ppc/tcg-target.inc.c:1377:9: note: in expansion of macro
> 'atomic_set'
> atomic_set((uint64_t *)jmp_addr, pair);
> ^
>
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> This fixes Shippable builds, see:
> https://app.shippable.com/github/qemu/qemu/runs/434/10/console
Reviewed-by: Richard Henderson <address@hidden>
r~