Re: [Qemu-devel] [PATCH 04/10] qemu-iotests: cleanup and fix search for programs

[Eric Blake]

On 09/12/2017 04:26 PM, Paolo Bonzini wrote:
> 
> 
>>> +then
>>> +    if [ -x "$build_iotests/qemu" ]; then
>>> +        export QEMU_PROG="$build_iotests/qemu"
>>> +    elif [ -x "$build_root/$arch-softmmu/qemu-system-$arch" ]; then
>>> +        export QEMU_PROG="$build_root/$arch-softmmu/qemu-system-$arch"
>>> +    else
>>> +        pushd "$build_root" > /dev/null
>>
>> Shouldn't you check for failure to change directories?
>>  
>>>  export PWD=`pwd`
>>>  
>>> @@ -30,28 +31,6 @@ export _QEMU_HANDLE=0
>>>  # make sure we have a standard umask
>>>  umask 022
>>>  
>>> -# $1 = prog to look for, $2* = default pathnames if not found in $PATH
>>> -set_prog_path()
>>> -{
>>> -    p=`command -v $1 2> /dev/null`
>>> -    if [ -n "$p" -a -x "$p" ]; then
>>
>> Urrgh - your use of [ -a ] was pre-existing, and you just moved it.
> 
> And same for pushd...

True - since this patch is just code motion, we can do the cleanups in a
different patch, so you can have:
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature