[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 17/22] s390x: CPU hot unplug via device_del canno
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [PATCH v5 17/22] s390x: CPU hot unplug via device_del cannot work for now |
Date: |
Wed, 13 Sep 2017 15:24:12 +0200 |
device_del on a CPU will currently do nothing. Let's emmit an error
telling that this is will currently not work (there is no architecture
support on s390x). Error message copied from ppc.
(qemu) device_del cpu1
device_del cpu1
CPU hot unplug not supported on this machine
Reviewed-by: Matthew Rosato <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/s390x/s390-virtio-ccw.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 9da9fd3994..3be81d96af 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -337,6 +337,15 @@ static void s390_machine_device_plug(HotplugHandler
*hotplug_dev,
}
}
+static void s390_machine_device_unplug_request(HotplugHandler *hotplug_dev,
+ DeviceState *dev, Error **errp)
+{
+ if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
+ error_setg(errp, "CPU hot unplug not supported on this machine");
+ return;
+ }
+}
+
static HotplugHandler *s390_get_hotplug_handler(MachineState *machine,
DeviceState *dev)
{
@@ -386,6 +395,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void
*data)
mc->max_cpus = 248;
mc->get_hotplug_handler = s390_get_hotplug_handler;
hc->plug = s390_machine_device_plug;
+ hc->unplug_request = s390_machine_device_unplug_request;
nc->nmi_monitor_handler = s390_nmi;
}
--
2.13.5
- Re: [Qemu-devel] [PATCH v5 11/22] s390x: allow only 1 CPU with TCG, (continued)
[Qemu-devel] [PATCH v5 12/22] target/s390x: set cpu->id for linux user when realizing, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 14/22] target/s390x: rename next_cpu_id to next_core_id, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 13/22] target/s390x: use "core-id" for cpu number/address/id handling, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 15/22] s390x: print CPU definitions in sorted order, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_add, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 17/22] s390x: CPU hot unplug via device_del cannot work for now,
David Hildenbrand <=
[Qemu-devel] [PATCH v5 18/22] s390x: implement query-hotpluggable-cpus, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 19/22] s390x: get rid of cpu_states and use possible_cpus instead, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 20/22] s390x: get rid of cpu_s390x_create(), David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 21/22] s390x: generate sclp cpu information from possible_cpus, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 22/22] s390x: allow CPU hotplug in random core-id order, David Hildenbrand, 2017/09/13